Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix warning and error log messages #6299

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Prefix warning and error log messages #6299

merged 1 commit into from
Feb 27, 2019

Conversation

cjerdonek
Copy link
Member

Fixes #6298.

@cjerdonek cjerdonek added type: enhancement Improvements to functionality C: logging Information Logging labels Feb 25, 2019
@cjerdonek cjerdonek force-pushed the prefix-warn-messages branch 5 times, most recently from 791b426 to eba7807 Compare February 27, 2019 11:14
@cjerdonek
Copy link
Member Author

Okay, I updated the PR. I incorporated @pradyunsg's initial feedback (though in a modified form because I realized we probably want to handle deprecation warnings a bit differently).

Let me know if you have any additional suggestions and/or want to go with CRITICAL, etc.

pradyunsg
pradyunsg reviewed Feb 27, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, based on a quick web-only review.

@cjerdonek
Copy link
Member Author

Great, thanks much, both of you!

@cjerdonek cjerdonek merged commit 62cfaf0 into pypa:master Feb 27, 2019
@cjerdonek cjerdonek deleted the prefix-warn-messages branch February 27, 2019 12:55
@lock
Copy link

lock bot commented May 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: logging Information Logging type: enhancement Improvements to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permit warning and error messages to be distinguished from their text
3 participants
@cjerdonek @xavfernandez @pradyunsg